Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: On move_commit and squash_commit, update which commit is selected #495

Closed
tomngo opened this issue May 15, 2019 · 3 comments
Closed

Comments

@tomngo
Copy link

tomngo commented May 15, 2019

Problem description

Now that I have bound keys to move_commit in both directions, I find that pressing those keys repeatedly does something quite non-intuitive: it moves a different commit with each keypress. Instead, I expect and want to move the originally selected commit many times.

Preferred solution

Suppose you have commits:
A
B
C
D

and suppose you select B then invoke move_commit with down: true. The postcondition of that operation ought to be that the commits are in the order below, with B selected:
A
C
B
D

Alternatives

An alternative is to let a user create macros as described here. I believe that's cumbersome.

@tomngo
Copy link
Author

tomngo commented May 16, 2019

Further Enhancement

In addition to the move_commit treatment above, there's the analogous treatment of squash_commit. If I squash A with B producing C, I proposed to wind up with C selected.

@tomngo tomngo changed the title Request: On move_commit, update which commit is selected Request: On move_commit and squash_commit, update which commit is selected May 16, 2019
@tomngo
Copy link
Author

tomngo commented May 16, 2019

Today, move_commit behaves as I expect (it matches the Preferred Solution above). Unless I am losing it, it was not behaving that way when I posted this enhancement request. I was on Build 1107 both times. Perhaps there's some circumstance that accounts for the difference, but I haven't pinpointed it.

@jskinner
Copy link
Member

jskinner commented Jun 3, 2019

This should be fixed in 1116, please reopen the issue if it isn't

@jskinner jskinner closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants