build 3183 crashing shortly after startup on macOS

[tillt]

Description

After having updated Sublime on two of my machines, on one it works just fine but on the other it quickly crashes after startup.

Steps to reproduce

No actions needed, it just crashes without me touching anything after about 20seconds.

Expected behavior

No crash.

Actual behavior

Segmentation fault.

Environment

• Build: 3183
• Operating system and version: 10.14.2 beta (18C52a)

Stacktrace for crashing thread:

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000108e5b000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [2825]

VM Regions Near 0x108e5b000:
    MALLOC_LARGE           0000000108e15000-0000000108e5b000 [  280K] rw-/rwx SM=COW  
--> 
    MALLOC_LARGE_REUSABLE  0000000108e5e000-0000000108f8f000 [ 1220K] rw-/rwx SM=PRV  

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.sublimetext.3             	0x000000010510adf0 next_token(usubstring) + 48
1   com.sublimetext.3             	0x000000010510b84a lex(lex_working_memory&, LexerState*, usubstring, std::__1::vector<TokenInfo, std::__1::allocator<TokenInfo> >&) + 2042
2   com.sublimetext.3             	0x000000010511d807 TokenStorage::tokenise(BucketContainer<tree_list<TokenBuffer, TokenBuffer::token_list_ops>, TokenStorage::TokenBufferFactory>::iterator, long long, LexerState*, usubstring) + 663
3   com.sublimetext.3             	0x000000010511b6cf TokenStorage::insertCharacters(long long, usubstring) + 671
4   com.sublimetext.3             	0x000000010540cf7b process_read_data(ReadData*) + 1310
5   com.sublimetext.3             	0x000000010540c13f FileBufferSource::beginRead(TextBuffer*, TokenStorage*) + 623
6   com.sublimetext.3             	0x000000010544999b TextBuffer::associate(BufferSource*) + 207
7   com.sublimetext.3             	0x00000001051bdbd4 crawl_app_loader::callback_finished() + 1366
8   com.sublimetext.3             	0x000000010527df7f setup_operation::request_finished() + 33
9   com.sublimetext.3             	0x000000010523fdb8 catalogue_rescan_operation::merge_finished(catalogue::dir*) + 160
10  com.sublimetext.3             	0x000000010524103a catalogue_rescan_operation::scan_callback::main_scan_single_dir(substring, std::__1::vector<file_info, std::__1::allocator<file_info> > const&) + 3916
11  com.sublimetext.3             	0x0000000105225fef result_helper::process_main() + 15
12  com.sublimetext.3             	0x00000001052c1704 -[WorkQueueCallback processItems:] + 151
13  com.apple.Foundation          	0x00007fff51946bab __NSThreadPerformPerform + 327
14  com.apple.CoreFoundation      	0x00007fff4f568475 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
15  com.apple.CoreFoundation      	0x00007fff4f56841b __CFRunLoopDoSource0 + 108
16  com.apple.CoreFoundation      	0x00007fff4f54beb5 __CFRunLoopDoSources0 + 195
17  com.apple.CoreFoundation      	0x00007fff4f54b45e __CFRunLoopRun + 1219
18  com.apple.CoreFoundation      	0x00007fff4f54ad48 CFRunLoopRunSpecific + 463
19  com.apple.Foundation          	0x00007fff518b14aa -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 280
20  com.sublimetext.3             	0x00000001052c981b px_run_event_loop() + 137
21  com.sublimetext.3             	0x00000001050ff65a main + 5700
22  com.sublimetext.3             	0x00000001050fdd84 start + 52

[wbond]

What syntax is being applied to the open files when you open your editor?

[tillt]

The open files are:

• Changelog in the foreground via popup
• Package Control Messages tab (update of gitgutter)
• iTerm color theme file (plain text syntax)
• .bashrc (Bash syntax)
• couple of headers and c++ implementation files (C++11 syntax)

I then went ahead, closed them 1 by 1 while quickly quitting Sublime to make sure the state was persisted. After I went through this exercise will all formerly opened files, I still end up with a crash even though the starting point now was 0 files open.

I then went ahead and closed both of the open projects, one by one.

• Python based Sublime plugin repo (RTagsComplete git)
• C++ based big project (Apache Mesos git)

After having closed the last project, quitting Sublime and reopening it, things stabilised - Sublime would not crash anymore on startup.

Then I re-opened that C++ project again and after a moment sublime crashed again.

-> That hints that the problem is within the C++ project or its git repo - not sure if the SCM plays a role in that stack-trace.

[wbond]

Awesome, thanks for taking the time to do that debugging. I will try cloning the Mesos git repo and see if I can reproduce.

[tillt]

Trouble is, I have a clone of the same project open (also same branch) on the machine that does not show crashes - so my hopes that you will be able to repro this are slim :(

[wbond]

This was fixed in build 3186