Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Guide Highlights Incorrect Block #555

Closed
jlmakes opened this issue Nov 6, 2014 · 5 comments
Closed

Active Guide Highlights Incorrect Block #555

jlmakes opened this issue Nov 6, 2014 · 5 comments

Comments

@jlmakes
Copy link

jlmakes commented Nov 6, 2014

I’ve put together a few screenshots showing how active guides frequently highlight the wrong code block. For example, the desired behavior of Fig. 3 would be to highlight the guide seen in Fig. 2.

OSX 10.10 (Yosemite)
Sublime Text 3 Build 3065


Fig 1. (Correct)

1


Fig 2. (Too close!!)

2


Fig 3. (Too close!!)

3


Fig 4. (Correct)

4


Fig 5. (Too close!!)

5


Perhaps I am using unconventional formatting — but I thought I would bring it up, as I would love the desired behavior; the way it is right now is a little... 😒

🍻

@FichteFoll
Copy link
Collaborator

Could you please paste the sample code, the syntax name you were using, the color scheme and your user settings?

I can't really reproduce this.

@jlmakes
Copy link
Author

jlmakes commented Nov 6, 2014

Sure @FichteFoll

I’m just using JavaScript syntax highlighting.

Source

/**
 * Sample API route
 */
var database = require( '../models' )

exports.index = function( req, res ) {

    database
        .User
        .findAll()
        .success(function( users ) {
            if ( users ) res.json( users )
            else         res.send( 401, 'Users not found' )
        })

    .error(function( err ) {
        res.send( 'Users not found' )
    })
}

Config

{
    "auto_complete_commit_on_tab": false,
    "auto_complete_delay": 300,
    "bold_folder_labels": true,
    "caret_extra_width": 1,
    "caret_style": "phase",
    "color_scheme": "Packages/User/Fisssion.tmTheme",
    "custom_folder_icons": true,
    "detect_indentation": false,
    "detect_slow_plugins": false,
    "draw_centered": true,
    "ensure_newline_at_eof_on_save": true,
    "fade_fold_buttons": false,
    "file_exclude_patterns":
    [
        "*.css",
        ".DS_Store"
    ],
    "folder_exclude_patterns":
    [
        ".git",
        ".sass-cache",
        "tmp"
    ],
    "font_face": "Fira Mono OT",
    "font_options":
    [
        "no_round"
    ],
    "font_size": 14.0,
    "highlight_line": true,
    "ignored_packages":
    [
    ],
    "indent_guide_options":
    [
        "draw_normal",
        "draw_active"
    ],
    "line_padding_bottom": -2,
    "line_padding_top": -2,
    "open_files_in_new_window": false,
    "rulers":
    [
        110
    ],
    "scroll_past_end": true,
    "show_tab_close_buttons": false,
    "tab_size": 4,
    "theme": "Cobalt2.sublime-theme",
    "translate_tabs_to_spaces": true,
    "trim_trailing_white_space_on_save": true,
    "vintage_start_in_command_mode": true,
    "word_wrap": "true",
    "wrap_width": 110
}

Theme

Fisssion.tmTheme — Download

@jlmakes
Copy link
Author

jlmakes commented Nov 7, 2014

Here is a screenshot straight from the config…

screen shot 2014-11-06 at 9 32 10 pm

A more useful Active Guide would be the one connecting the square brackets.

@FichteFoll
Copy link
Collaborator

Still can not reproduce. Might be yet another Yosemite issue because afaik this hasn't come up before.

2014-11-07_18 59 14

@jlmakes
Copy link
Author

jlmakes commented Nov 7, 2014

I’ve narrowed it down to an issue with the font I was using (Fira Mono OT). It seems to be that when sized at 14px, it tricks the editor into drawing an extra guide. It would seem that certain font and font-size combinations cause this issue.

Switched to Ubuntu Mono and all is right with the world.

Thanks for taking the time @FichteFoll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants