Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable syntax-based code folding #5709

Closed
BenjaminSchaaf opened this issue Nov 17, 2022 · 6 comments
Closed

Add setting to disable syntax-based code folding #5709

BenjaminSchaaf opened this issue Nov 17, 2022 · 6 comments
Assignees
Milestone

Comments

@BenjaminSchaaf
Copy link
Member

Problem description

Some customers rely heavily on the indentation-based code folding and the new syntax-based code folding breaks their workflow.

Preferred solution

Add a setting

Alternatives

N/A

Additional Information

No response

@BenjaminSchaaf
Copy link
Member Author

Fixed in build 4144.

@coodoo
Copy link

coodoo commented Feb 4, 2023

@BenjaminSchaaf Just noticed this issue had been fixed, upgraded to the latest dev builds 4147 and everything seemed to work fine, thanks a lot for making Sublime Text slick again! 🙌❤️

Added "fold_style" setting, making it easy to disable syntax-based code folding

@axsuul
Copy link

axsuul commented Mar 4, 2023

The default code folding behavior still seems to be broken on build 4147, even with "fold_style": "force_indentation". Here's example Ruby code it doesn't fold properly on Fold Level 2

CleanShot 2023-03-03 at 18 24 19@2x

However, reverting back to build 4126 and doing Fold Level 2 folds properly

CleanShot 2023-03-03 at 18 25 17@2x

@BenjaminSchaaf
Copy link
Member Author

@axsuul it's working fine here:

code-folding.mp4

@axsuul
Copy link

axsuul commented Mar 4, 2023

Ah, thanks for that! Doh, can't figure out why it's not working for me 😬

@BenjaminSchaaf
Copy link
Member Author

Are you perhaps selecting everything before folding by level? Does it happen in safe mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants