Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of VLS server #24

Closed
wants to merge 1 commit into from
Closed

Update to latest version of VLS server #24

wants to merge 1 commit into from

Conversation

rchl
Copy link
Member

@rchl rchl commented Apr 13, 2020

The vue-language-server is now published under vls package:
https://www.npmjs.com/package/vls

The root version in package.json doesn't really matter as we are
comparing whole files with cached version so it's enough that we
change dependency version for update to trigger.

Resolves #23

The `vue-language-server` is now published under `vls` package:
https://www.npmjs.com/package/vls

The root version in package.json doesn't really matter as we are
comparing whole files with cached version so it's enough that we
change dependency version for update to trigger.

Resolves #23
@predragnikolic
Copy link
Member

I get an error: Language server lsp-vue has crached. Do you want to restart it?.

The error is the following:

lsp-vue: /home/predrag/.config/sublime-text/Cache/LSP-vue/server/node_modules/eslint/lib/cli-engine/config-array/config-array.js:180
lsp-vue: throw sourceValue.error;
lsp-vue: ^
lsp-vue: 
lsp-vue: Error: Failed to load plugin 'vue' declared in 'CLIOptions': Cannot find module 'eslint-plugin-vue'

I deleted the node_modules restarted to sublime to reinstalled the server again, but the same error happened again.
I will have to dig a bit to see the cause.

@rchl
Copy link
Member Author

rchl commented Apr 13, 2020

I don't know if it's the same issue for you but I got tricked into similar issues by having server/node_modules in my LSP-vue repository. When you have that then that will be copied to Cache and npm install won't run there, ending up with possibly out-of-sync node_modules.

@predragnikolic
Copy link
Member

Good to know, but I don't have node_modules in the Packages/LSP-vue/server folder

λ  LSP-vue rchl/maintenace/update-vls ✗ ls
app.vue            LSP-vue.sublime-commands  plugin.py  tox.ini
dependencies.json  LSP-vue.sublime-settings  README.md
LICENSE            Main.sublime-menu         server
λ  LSP-vue rchl/maintenace/update-vls ✗ cd server 
λ  LSP-vue/server rchl/maintenace/update-vls ✗ ls
package.json  package-lock.json

@rchl
Copy link
Member Author

rchl commented Apr 13, 2020

Apparently this is fixed upstream but updated vls package wasn't released yet: vuejs/vetur#1840

@rchl
Copy link
Member Author

rchl commented Jul 22, 2020

Superseded by #68.

@rchl rchl closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language server lsp-vue has crashed, do you want to restart it?
2 participants