Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket_server installs a root logger #2477

Closed
kaste opened this issue May 17, 2024 · 0 comments 路 Fixed by #2478
Closed

websocket_server installs a root logger #2477

kaste opened this issue May 17, 2024 · 0 comments 路 Fixed by #2478

Comments

@kaste
Copy link

kaste commented May 17, 2024

Hi 馃槈 , I from time to time get to see logs with double logging in SublimeLinter-land. E.g.

SublimeLinter: log_handler.py:77      Logging installed; log level INFO
INFO:SublimeLinter:Logging installed; log level INFO

The first line comes from the SublimeLinter handler/formatter but I never figured out where the second line comes from.
Just by luck, I finally found it:

LSP/third_party/websocket_server/websocket_server.py

Line 18 in 723b129

logging.basicConfig()

This installs a root logger. Don't think that's even intended here. Probably just deleting the line will be 馃啑 .
predragnikolic added a commit that referenced this issue May 20, 2024
@predragnikolic
remove logging.basicConfig()
60e1768 
Avoid polluting other packages

closes #2477
@predragnikolic predragnikolic mentioned this issue May 20, 2024
Merged
predragnikolic added a commit that referenced this issue May 29, 2024
@predragnikolic
Remove logging.basicConfig() (#2478)
8d8f5c7 
* remove logging.basicConfig()

Avoid polluting other packages

closes #2477

* Revert "remove logging.basicConfig()"

This reverts commit 60e1768.

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove logging.basicConfig() sublimelsp/LSP
1 participant
@kaste