New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ls is resarted every time the view is focused #448
Comments
These two views cause LSP think your window has reopened with a different root path. |
yes, I have a sublime project with one folder {
"folders":
[
{
"path": "C:\\Users\\User\\AppData\\Roaming\\Sublime Text 3\\Packages\\User\\sublime-ui"
}
]
} this happens wether all files are in the project or not, and not only when switching from one file to another, basically whenever the view loses focus and regains it. |
I could repro this today while fixing the Javascript syntax issue
This javascript file doesn't live under your Code-Profiler folder (or sublime-ui, but I guess that's a different example). Maybe you can help narrow down if it happens with two files of the same language? Both inside the project or one outside. Or only if the other file is also another language? How many windows are you running? |
so far i haven't get why it does that, but i changed the import sublime
...
def _end_old_sessions(self):
project = get_project_path(self._window)
if project != self._project_path:
debug('project path changed, ending existing sessions', self._project_path, ' ==> ', project)
debug('windows: ', sublime.active_window().id(), ' ==> ', self._window.id())
self.end_sessions() hopefully it helps
here i sitched project from LSP to Chrome Dino
Observations
|
This was a pretty obvious mistake, once I realised that quick switching once could be the trigger. |
This is supposed to be fixed now @AmjadHD, do you have some spare time to check this out on the latest master? |
At first, I didn't know it has something to do with switching project, as for the issue it is fixed as the ls is no longer restarted on view focus, but it's no longer started at all (after switching):
|
@rwols I didn't look too closely at the changes in This means the sessions aren't removed and new sessions won't start. |
Yes, my bad. I have a proposed fix for that here: #458. |
PR is merged, servers should restart now after switching project! |
surely, thanks for fixing this. |
Minimal reproduction steps
Log
The text was updated successfully, but these errors were encountered: