Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pip): compare requirements.txt files instead of packages #97

Merged
merged 6 commits into from
Mar 6, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Mar 3, 2023

No description provided.

@rchl rchl changed the title fix(pip): ignore comment lines in requirements.txt fix(pip): compare requirements.txt files instead of actual packages Mar 4, 2023
@rchl
Copy link
Member Author

rchl commented Mar 4, 2023

@LDAP I made this change to fix sublimelsp/LSP-ruff#10.

I'm not quite sure why we were comparing individual package versions instead of the actual content of the requirements.txt file when checking whether server needs to be upgraded. That seemed a little over-engineered...

@rchl rchl changed the title fix(pip): compare requirements.txt files instead of actual packages fix(pip): compare requirements.txt files instead of packages Mar 4, 2023
* origin/master:
  Allow use of electron runtime for Node-based servers (#96)
@rchl rchl merged commit 1cf45dc into master Mar 6, 2023
@rchl rchl deleted the fix/pip-requirements branch March 6, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants