Add LSP-PowerShellEditorServices

[github-actions]

Repo link

https://github.com/sublimelsp/LSP-PowerShellEditorServices

Release body

This release contains version v2.2.0 of PowerShellEditorServices.
Sublime-Text-Version-Range: >=4070

[rchl]

OK... With a simple CURL action I can finally see what's wrong:

{"message":"Unprocessable Entity","errors":["Can not request changes on your own pull request"]

So it's indeed related to this PR being created by the bot.

[rchl]

I think the solution for that is to have a bot account that will have its own token and we'll use that for the review bot.

[rwols]

Or...

How about not reporting results via a quirky "request changes" comment, but rather look at the failed actions.

[rwols]

This should be enough information:

[rchl]

That's not very user friendly, having to look for details of the error in the shell output...

[rwols]

The repository json checks could also be presented as "annotations" https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-status-checks

[STReviewBot]

Automated testing result: ERROR

Repo link: LSP-PowerShellEditorServices
Results help

Packages added:
  - LSP-PowerShellEditorServices

Processing package "LSP-PowerShellEditorServices"
  - ERROR: fetching package HTTP error 302 downloading https://github.com/sublimelsp/LSP-PowerShellEditorServices/releases/download/v1.1.1/LSP-PowerShellEditorServices.zip.

[rchl]

The repository json checks could also be presented as "annotations" docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-status-checks

Right, but I feel that would be pretty tricky to implement since the checks don't really keep track of line numbers right now. I mean the review bot checks at least.

[rchl]

Need to figure out a solution for the redirect issue.

[rwols]

There's an issue for it wbond/package_control#1502

[rchl]

Do you think we should wait for that or implement a solution on our side (have links that don't redirect)?

[rwols]

It should be fixed in package control because we might not be the only ones having this issue.

[rchl]

Yes but ST3 version of PC will not get a fix so if we want to support some ST3 packages then we should probably do something ourselves. That said, I guess the ones you've created are all ST4+.

EDIT: Actually LSP-lua isn't.

[rwols]

I give up. Let's download all the files with our own tooling. Made the appropriate reverts in the helper package repo.

[STReviewBot]

Automated testing result: ERROR

Repo link: LSP-PowerShellEditorServices
Results help

Packages added:
  - LSP-PowerShellEditorServices

Processing package "LSP-PowerShellEditorServices"
  - ERROR: fetching package HTTP error 302 downloading https://github.com/sublimelsp/LSP-PowerShellEditorServices/releases/download/v1.1.1/LSP-PowerShellEditorServices.zip.

[STReviewBot]

Automated testing result: ERROR

Repo link: LSP-PowerShellEditorServices
Results help

Packages added:
  - LSP-PowerShellEditorServices

Processing package "LSP-PowerShellEditorServices"
  - ERROR: fetching package HTTP error 302 downloading https://github.com/sublimelsp/LSP-PowerShellEditorServices/releases/download/v1.1.1/LSP-PowerShellEditorServices.zip.

[rwols]

Why aren't you picking up tag 1.1.2 @STReviewBot ?

[predragnikolic]

Is it maybe because of the "url" or the "version" key?

[STReviewBot]

Automated testing result: WARNING

Repo link: LSP-PowerShellEditorServices
Results help

Packages added:
  - LSP-PowerShellEditorServices

Processing package "LSP-PowerShellEditorServices"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 23, Column: 12
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 117, Column: 11
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 121, Column: 12