forked from michaelpnash/sublime-ensime
-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #83 from dvinokurov/issue79
Fixed error while generating message before creating project from SBT
- Loading branch information
Showing
3 changed files
with
13 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
def encode_if_unicode(arg): | ||
if isinstance(arg,list): | ||
return [encode_if_unicode(elem) for elem in arg] | ||
return arg.encode("utf-8") if isinstance(arg, unicode) else arg | ||
|
||
def decode_if_str(arg): | ||
if isinstance(arg,list): | ||
return [decode_if_str(elem) for elem in arg] | ||
return arg.decode("utf-8") if isinstance(arg, str) else arg |
76aafe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit seems to have broken the plugin as it is missing an import statement in ensime.py (from strings import *). So the two new functions in strings.py are not available there.
76aafe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reporting. Going to revert asap.
76aafe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just a single line missing. My system worked after adding the import statement to ensime.py.
76aafe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check now?
76aafe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, works perfectly well now. Thanks for the quick response.
76aafe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
76aafe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that was my fault. Probably missed the import statement while rebasing.
Thank you