Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment alignments #125

Merged
merged 3 commits into from Mar 10, 2021
Merged

Deployment alignments #125

merged 3 commits into from Mar 10, 2021

Conversation

SteveMattar
Copy link
Contributor

@SteveMattar SteveMattar commented Mar 4, 2021 •
edited

  • refactor: globalnet should be under the broker
  • feat: support ovn
  • feat: add lighthouse to e2e matrix

@SteveMattar SteveMattar enabled auto-merge (rebase) March 4, 2021 23:45
@SteveMattar SteveMattar force-pushed the broker-values branch 8 times, most recently from d91844f to ccc88ed Compare March 7, 2021 00:47
@SteveMattar SteveMattar changed the title broker values Deployment alignments Mar 7, 2021
@SteveMattar SteveMattar force-pushed the broker-values branch 3 times, most recently from 5de3679 to cd666aa Compare March 7, 2021 03:04
@SteveMattar SteveMattar added this to In review in Submariner Project v0.9 Mar 7, 2021
@SteveMattar SteveMattar added this to the 0.9-m2 milestone Mar 7, 2021
@nyechiel nyechiel added the Helm label Mar 7, 2021
dfarrell07
dfarrell07 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@dfarrell07 dfarrell07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @SteveMattar!

submariner/questions.yml Outdated Show resolved Hide resolved
submariner-operator/questions.yml Outdated Show resolved Hide resolved
Steve Mattar added 3 commits March 9, 2021 13:08
refactor: globalnet should be under the broker
b56034d 
Signed-off-by: Steve Mattar <smattar@redhat.com>
feat: support ovn
2f2b6b2 
Signed-off-by: Steve Mattar <smattar@redhat.com>
feat: add lighthouse to e2e matrix
8eaf6e9 
Signed-off-by: Steve Mattar <smattar@redhat.com>
@dfarrell07
Copy link
Member

I retriggered your CI and everything is passing now @SteveMattar. 🥳

dfarrell07
dfarrell07 requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@dfarrell07 dfarrell07 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<ignore, sorry>

@SteveMattar SteveMattar mentioned this pull request Mar 10, 2021
Merged
@SteveMattar SteveMattar merged commit c450f75 into submariner-io:devel Mar 10, 2021
Submariner Project v0.9 automation moved this from In review to Done Mar 10, 2021
@SteveMattar SteveMattar deleted the broker-values branch March 15, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@tpantelis tpantelis tpantelis approved these changes

@mangelajo mangelajo Awaiting requested review from mangelajo

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

Assignees
No one assigned
Labels
Helm
Projects
No open projects
Submariner Project v0.9
Done
Milestone
0.9-m2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SteveMattar @dfarrell07 @tpantelis @nyechiel