Subctl diagnose all should run on all clusters

Make sure that subctl diagnose all will execute all checks even if one check failed Also applys to ExecuteMultiCluster when need to execute command on multiple clusters Signed-off-by: Maayan Friedman <maafried@redhat.com>
submariner-io · Jun 18, 2021 · 8eb5ecb · 8eb5ecb
1 parent 6481d73
commit 8eb5ecb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/pkg/subctl/cmd/diagnose/all.go b/pkg/subctl/cmd/diagnose/all.go
@@ -47,25 +47,25 @@ func diagnoseAll(cluster *cmd.Cluster) bool {
 		return success
 	}
 
-	success = success && checkCNIConfig(cluster)
+	success = checkCNIConfig(cluster) && success
 	fmt.Println()
 
-	success = success && checkConnections(cluster)
+	success = checkConnections(cluster) && success
 	fmt.Println()
 
-	success = success && checkPods(cluster)
+	success = checkPods(cluster) && success
 	fmt.Println()
 
-	success = success && checkOverlappingCIDRs(cluster)
+	success = checkOverlappingCIDRs(cluster) && success
 	fmt.Println()
 
-	success = success && checkKubeProxyMode(cluster)
+	success = checkKubeProxyMode(cluster) && success
 	fmt.Println()
 
-	success = success && checkFirewallMetricsConfig(cluster)
+	success = checkFirewallMetricsConfig(cluster) && success
 	fmt.Println()
 
-	success = success && checkVxLANConfig(cluster)
+	success = checkVxLANConfig(cluster) && success
 	fmt.Println()
 
 	fmt.Printf("Skipping tunnel firewall check as it requires two kubeconfigs." +

diff --git a/pkg/subctl/cmd/execute.go b/pkg/subctl/cmd/execute.go
@@ -99,7 +99,7 @@ func ExecuteMultiCluster(run func(*Cluster) bool) {
 			continue
 		}
 
-		success = success && run(cluster)
+		success = run(cluster) && success
 		fmt.Println()
 	}