Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a cluster id is invalid, show the error #1424

Merged
merged 2 commits into from Jun 18, 2021

Conversation

skitt
Copy link
Member

@skitt skitt commented Jun 17, 2021

Currently, if the cluster id specified using the relevant option or
generated from the context name is invalid, we ask the user for a
cluster id with no introduction. This patch shows the error before
prompting.

Signed-off-by: Stephen Kitt skitt@redhat.com

Currently, if the cluster id specified using the relevant option or
generated from the context name is invalid, we ask the user for a
cluster id with no introduction. This patch shows the error before
prompting.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1424/skitt/show-valid-error
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jun 17, 2021
@tpantelis tpantelis enabled auto-merge (rebase) June 17, 2021 15:02
@tpantelis tpantelis merged commit 5f531ea into submariner-io:devel Jun 18, 2021
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1424/skitt/show-valid-error]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants