Add config field for nodePlacement #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthapar
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2530/vthapar/node-placement |
skitt
requested changes
Mar 8, 2023
| @@ -47,6 +48,10 @@ type ServiceDiscoverySpec struct { | |||
| // +listType=set | |||
| CustomDomains []string `json:"customDomains,omitempty"` | |||
| ImageOverrides map[string]string `json:"imageOverrides,omitempty"` | |||
| // +optional | |||
| NodeSelector map[string]string `json:"nodeSelector,omitempty"` | |||
There was a problem hiding this comment.
Shouldn’t this be
Suggested change
| NodeSelector map[string]string `json:"nodeSelector,omitempty"` | |
| NodeSelector v1.NodeSelector `json:"nodeSelector,omitempty"` |
?
There was a problem hiding this comment.
I don't think there is a type NodeSelector. Even PodSpec uses map[string]string
https://github.com/kubernetes/api/blob/master/core/v1/types.go#L3273
// NodeSelector is a selector which must be true for the pod to fit on a node.
// Selector which must match a node's labels for the pod to be scheduled on that node.
// More info: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
// +optional
// +mapType=atomic
NodeSelector map[string]string `json:"nodeSelector,omitempty" protobuf:"bytes,7,rep,name=nodeSelector"`
There was a problem hiding this comment.
There is a NodeSelector type, hence my question: https://pkg.go.dev/k8s.io/api/core/v1#NodeSelector. I’ve seen it used in other specs, but it doesn’t really seem to be appropriate for that; let’s follow PodSpec.
|
🤖 Closed branches: [z_pr2530/vthapar/node-placement] |
|
🤖 Created branch: z_pr2530/vthapar/node-placement |
Epic submariner-io/enhancements#149 Refer submariner-io/enhancements#156 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
skitt
approved these changes
Mar 9, 2023
|
🤖 Closed branches: [z_pr2530/vthapar/node-placement] |
|
🤖 Created branch: z_pr2530/vthapar/node-placement |
dfarrell07
approved these changes
Mar 13, 2023
|
🤖 Closed branches: [z_pr2530/vthapar/node-placement] |
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 19, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 19, 2023
Add get, list and watch permissions for AddonDeploymentConfig so submariner addon can track changes to it. Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
openshift-merge-robot
pushed a commit
to stolostron/submariner-addon
that referenced
this pull request
Apr 19, 2023
Add get, list and watch permissions for AddonDeploymentConfig so submariner addon can track changes to it. Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 26, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 26, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 26, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 26, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 27, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 27, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 27, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 27, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
added a commit
to vthapar/submariner-addon
that referenced
this pull request
Apr 27, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
openshift-merge-robot
pushed a commit
to stolostron/submariner-addon
that referenced
this pull request
May 2, 2023
Refer submariner-io/submariner-operator#2530 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
dfarrell07
removed
the
release-note-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic submariner-io/enhancements#149
Refer submariner-io/enhancements#156