Add globalnet-cluster-size option to join #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr288/vthapar/globalnet-issue-268 |
vthapar
force-pushed
the
globalnet-issue-268
branch
from
f062f69
to
b284efd
Compare
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
sridhargaddam
approved these changes
Mar 31, 2020
| @@ -90,6 +90,8 @@ func addJoinFlags(cmd *cobra.Command) { | |||
| cmd.Flags().StringVar(&cableDriver, "cable-driver", "", "Cable driver implementation") | |||
| cmd.Flags().BoolVar(&disableOpenShiftCVO, "disable-cvo", false, | |||
| "disable OpenShift's cluster version operator if necessary, without prompting") | |||
| cmd.Flags().UintVar(&globalnetClusterSize, "globalnet-cluster-size", 0, | |||
There was a problem hiding this comment.
I think in future we may want to support specifying an all-together different CIDR as part of join operation via globalnet-cidr flag. This is outside the scope of the current PR.
dfarrell07
approved these changes
Apr 1, 2020
vthapar
force-pushed
the
globalnet-issue-268
branch
from
b284efd
to
d609526
Compare
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
vthapar
force-pushed
the
globalnet-issue-268
branch
from
d609526
to
ed05254
Compare
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
vthapar
force-pushed
the
globalnet-issue-268
branch
from
ed05254
to
7d3fbf2
Compare
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
vthapar
force-pushed
the
globalnet-issue-268
branch
from
7d3fbf2
to
2908ab6
Compare
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
vthapar
force-pushed
the
globalnet-issue-268
branch
from
2908ab6
to
d96cd9c
Compare
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
Currently --globalnet-cluster-size can be specified only during broker installation. This adds option to give a different size during join. Closes submariner-io#268
vthapar
force-pushed
the
globalnet-issue-268
branch
from
d96cd9c
to
962df34
Compare
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
sridhargaddam
approved these changes
Apr 8, 2020
| @@ -90,6 +90,8 @@ func addJoinFlags(cmd *cobra.Command) { | |||
| cmd.Flags().StringVar(&cableDriver, "cable-driver", "", "Cable driver implementation") | |||
| cmd.Flags().BoolVar(&disableOpenShiftCVO, "disable-cvo", false, | |||
| "disable OpenShift's cluster version operator if necessary, without prompting") | |||
| cmd.Flags().UintVar(&globalnetClusterSize, "globalnet-cluster-size", 0, | |||
mangelajo
suggested changes
Apr 8, 2020
Co-Authored-By: Miguel Angel Ajo Pelayo <miguelangel@ajo.es>
|
🤖 Updated branch: z_pr288/vthapar/globalnet-issue-268 |
mangelajo
approved these changes
Apr 8, 2020
|
🤖 Closed branches: [z_pr288/vthapar/globalnet-issue-268] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently --globalnet-cluster-size can be specified only during broker
installation. This adds option to give a different size during join.
Closes #268