Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin Kubernetes dependencies #1614

Closed
wants to merge 1 commit into from
Closed

Unpin Kubernetes dependencies #1614

wants to merge 1 commit into from

Conversation

skitt
Copy link
Member

@skitt skitt commented Dec 7, 2021

This doesn't seem to break anything, and helps with go install (see
golang/go#44840).

Signed-off-by: Stephen Kitt skitt@redhat.com

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1614/skitt/unpin-kubernetes
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt requested a review from dfarrell07 December 7, 2021 09:29
@dfarrell07 dfarrell07 mentioned this pull request Dec 7, 2021
Merged
@skitt skitt force-pushed the unpin-kubernetes branch 4 times, most recently from ba23506 to 01b507d Compare December 8, 2021 17:04
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Dec 13, 2021
@dfarrell07
Copy link
Member

I've tried re-running the UTs 6 times now, all 6 failed. 💀

@skitt
Copy link
Member Author

skitt commented Dec 15, 2021

I've tried re-running the UTs 6 times now, all 6 failed. skull

Yes, the errors here are related to GlobalIngressIP and are tied to the PR; they’re not the pinger error we’re getting on other PRs.

@skitt
Unpin Kubernetes dependencies
a11b901 
This doesn't seem to break anything, and helps with go install (see
<golang/go#44840>).

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@nyechiel nyechiel added this to In progress in Submariner Project 0.12 Dec 29, 2021
@nyechiel nyechiel moved this from In progress to In Review in Submariner Project 0.12 Dec 29, 2021
@stale
Copy link

stale bot commented Dec 31, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 31, 2021
@nyechiel nyechiel added confirmed For issues and PRs which we definitely want (disables the stale bot) and removed wontfix This will not be worked on labels Jan 2, 2022
@nyechiel
Copy link
Member

@skitt I assume we want this fixed for 0.12?

@skitt
Copy link
Member Author

skitt commented Feb 22, 2022

@skitt I assume we want this fixed for 0.12?

I would have liked it fixed for 0.12, but it’s too complex! We’ll have to punt it to 0.13.

@nyechiel nyechiel removed this from In Review in Submariner Project 0.12 Feb 22, 2022
@nyechiel nyechiel added this to Backlog in Backlog Feb 22, 2022
@nyechiel nyechiel moved this from Backlog to Work in progress in Backlog Mar 9, 2022
@tpantelis
Copy link
Contributor

This PR is outdated and no longer needed.

@tpantelis tpantelis closed this Jun 6, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1614/skitt/unpin-kubernetes]

@nyechiel nyechiel removed this from Work in progress in Backlog Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@tpantelis tpantelis tpantelis approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees
No one assigned
Labels
confirmed For issues and PRs which we definitely want (disables the stale bot) ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@skitt @submariner-bot @dfarrell07 @nyechiel @tpantelis