Automate calico ippools creation by routeagent #2576

yboaron · 2023-06-28T08:16:28Z

To make calico compatible with Submariner, it needs to create calico IPPools for the subnets associated with the Pod and Service CIDRs of the remote clusters.

This PR adds a new handler (CalicoIPPool) for the routeagent, the CalicoIPPool handler will be responsible for creating calico IPPools for remote endpoints, running Calico API server is a
prerequisite for automating Calico IPPools creation.

Depends-On : submariner-io/submariner-operator#2713

submariner-bot · 2023-06-28T08:16:32Z

🤖 Created branch: z_pr2576/yboaron/calico_ippool
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

pkg/routeagent_driver/handlers/calico/ippool_handler.go

tpantelis · 2023-06-29T12:09:51Z

pkg/routeagent_driver/handlers/calico/ippool_handler.go

+	remoteEndpoints map[string]*submV1.Endpoint
+	isGateway       bool


We should protect these with a mutex as is done in other handlers (eg ).

submariner/pkg/routeagent_driver/handlers/kubeproxy/gw_transition.go

Line 29 in c2cae00

kp.syncHandlerMutex.Lock()

Do you still think we should use mutex here ?

As discussed elsewhere it shouldn't be needed unless mutable fields can be accessed outside the parent's event loop. This appears to be the case with isGateway in the Stop method. To be completely safe, you can use an atomic bool for isGateway.

pkg/routeagent_driver/handlers/calico/ippool_handler.go

yboaron · 2023-07-06T08:29:49Z

Few observations after checking this PR on OCP with Calico clusters on IBM ROKS,

According to Calico recommendation we should use projectcalico.org/v3 to create IPPools and not crd.projectcalico.org/v1 (see [1] )
To enable projectcalico.org/v3 API the Calico API server should be installed in the cluster [2]
Calico API server not installed on OCP clusters on ROKS
After installing Calico API server by following the instructions from [2], Calico IPPools needed for Submariner created by this PR as expected.

I filed [3] issue on Calico project, let's wait for their reply to decide how to proceed with this PR

[1]
projectcalico/calico#6412
[2]
https://docs.tigera.io/calico/latest/operations/install-apiserver#how-to
[3]
projectcalico/calico#7845

tpantelis · 2023-07-13T15:08:10Z

pkg/routeagent_driver/handlers/calico/ippool_handler.go

+	remoteEndpoints map[string]*submV1.Endpoint
+	isGateway       bool


As discussed elsewhere it shouldn't be needed unless mutable fields can be accessed outside the parent's event loop. This appears to be the case with isGateway in the Stop method. To be completely safe, you can use an atomic bool for isGateway.

pkg/routeagent_driver/handlers/calico/ippool_handler.go

yboaron · 2023-07-17T07:46:55Z

Few observations after checking this PR on OCP with Calico clusters on IBM ROKS,

According to Calico recommendation we should use projectcalico.org/v3 to create IPPools and not crd.projectcalico.org/v1 (see [1] )

To enable projectcalico.org/v3 API the Calico API server should be installed in the cluster [2]

Calico API server not installed on OCP clusters on ROKS

After installing Calico API server by following the instructions from [2], Calico IPPools needed for Submariner created by this PR as expected.

I filed [3] issue on Calico project, let's wait for their reply to decide how to proceed with this PR

[1] projectcalico/calico#6412 [2] https://docs.tigera.io/calico/latest/operations/install-apiserver#how-to [3] projectcalico/calico#7845

Calico folks plan to work on providing a new API to create IPPools that can be used regardless to the Calico API server , until this API will be available running Calico API server is a prerequisite for automating Calico IPPools creation.

pkg/routeagent_driver/handlers/calico/ippool_handler.go

To make calico compatible with Submariner, it needs to create calico IPPools for the subnets associated with the Pod and Service CIDRs of the remote clusters. This PR adds a new handler (CalicoIPPool) for the routeagent, the CalicoIPPool handler will be responsible for creating calico IPPools for remote endpoints. Depends-On : submariner-io/submariner-operator#2713 Signed-off-by: Yossi Boaron <yboaron@redhat.com>

submariner-bot · 2023-07-25T03:12:12Z

🤖 Closed branches: [z_pr2576/yboaron/calico_ippool]

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

yboaron requested review from Oats87, skitt, sridhargaddam and tpantelis as code owners June 28, 2023 08:16

yboaron force-pushed the calico_ippool branch from b15126a to cbf9cfb Compare June 28, 2023 14:18

dfarrell07 added the release-note-needed Should be mentioned in the release notes label Jun 28, 2023

tpantelis requested changes Jun 29, 2023

View reviewed changes

yboaron force-pushed the calico_ippool branch from cbf9cfb to 4f36433 Compare July 2, 2023 15:34

nyechiel requested a review from tpantelis July 3, 2023 11:43

skitt added the ready-to-test When a PR is ready for full E2E testing label Jul 7, 2023

tpantelis requested changes Jul 13, 2023

View reviewed changes

yboaron force-pushed the calico_ippool branch from 4f36433 to 6e355a3 Compare July 17, 2023 07:35

yboaron requested a review from tpantelis July 17, 2023 07:37

yboaron force-pushed the calico_ippool branch from 6e355a3 to cfa7146 Compare July 17, 2023 07:53

tpantelis approved these changes Jul 17, 2023

View reviewed changes

sridhargaddam reviewed Jul 19, 2023

View reviewed changes

pkg/routeagent_driver/handlers/calico/ippool_handler.go Show resolved Hide resolved

yboaron force-pushed the calico_ippool branch from cfa7146 to 9ae8883 Compare July 20, 2023 06:50

yboaron requested a review from sridhargaddam July 20, 2023 10:20

sridhargaddam approved these changes Jul 24, 2023

View reviewed changes

Merge branch 'devel' into calico_ippool

17162b5

sridhargaddam enabled auto-merge (rebase) July 24, 2023 13:17

sridhargaddam merged commit d48ecae into submariner-io:devel Jul 25, 2023
37 checks passed

dfarrell07 mentioned this pull request Oct 5, 2023

Release 0.16.0 submariner-io/releases#723

Closed

tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Oct 17, 2023

Add release note for submariner PR#2576

32c1610

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

tpantelis mentioned this pull request Oct 17, 2023

Add release note for submariner PR#2576 submariner-io/submariner-website#1054

Merged

tpantelis added the release-note-handled label Oct 17, 2023

tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Oct 18, 2023

Add release note for submariner PR#2576

01b8a6f

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Oct 18, 2023

Add release note for submariner PR#2576

77b590a

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 18, 2023

Add release note for submariner PR#2576

497cd0f

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 18, 2023

Add release note for submariner PR#2576

680607a

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 19, 2023

Add release note for submariner PR#2576

3f657b2

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Oct 22, 2023

Add release note for submariner PR#2576

f9f9d07

Release note for submariner-io/submariner#2576 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

yboaron deleted the calico_ippool branch February 14, 2024 12:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automate calico ippools creation by routeagent #2576

Automate calico ippools creation by routeagent #2576

yboaron commented Jun 28, 2023 •

edited

Loading

submariner-bot commented Jun 28, 2023

tpantelis Jun 29, 2023

yboaron Jul 2, 2023

tpantelis Jul 13, 2023

yboaron commented Jul 6, 2023 •

edited

Loading

tpantelis Jul 13, 2023

yboaron commented Jul 17, 2023 •

edited

Loading

submariner-bot commented Jul 25, 2023

Automate calico ippools creation by routeagent #2576

Automate calico ippools creation by routeagent #2576

Conversation

yboaron commented Jun 28, 2023 • edited Loading

submariner-bot commented Jun 28, 2023

tpantelis Jun 29, 2023

Choose a reason for hiding this comment

yboaron Jul 2, 2023

Choose a reason for hiding this comment

tpantelis Jul 13, 2023

Choose a reason for hiding this comment

yboaron commented Jul 6, 2023 • edited Loading

tpantelis Jul 13, 2023

Choose a reason for hiding this comment

yboaron commented Jul 17, 2023 • edited Loading

submariner-bot commented Jul 25, 2023

yboaron commented Jun 28, 2023 •

edited

Loading

yboaron commented Jul 6, 2023 •

edited

Loading

yboaron commented Jul 17, 2023 •

edited

Loading