feat: No more vektor! #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler to be echo func
|
|
cohix
reviewed
Feb 6, 2023
…lous-devektorification-of-one-e2core
|
I've added all my thoughts, I haven't had a chance to test manually, so other folks should do that before merging. |
In systempec, commit suborbital/systemspec@761c3aa removed handling of queries and static files.
1 task
|
Manually validated se2 main against this version of e2core, appears to work as expected based on the existing execution. We may have a bit of a poison pill issue with the syncer which isn't within the scope of the PR but warrants future investigation. |
…lous-devektorification-of-one-e2core
arbourd
approved these changes
Feb 10, 2023
ospencer
approved these changes
Feb 10, 2023
javorszky
deleted the
gabor/357-minutes-of-meeting-and-the-fantabulous-devektorification-of-one-e2core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #357
This is a work in progress, but the broad strokes is that vlog -> zerolog, and vk.server -> echo. This depends on some gokit work, so I'll be tackling that first, and then I'll need to make sure the tests actually pass.