feat(web): Add a custom error handler to gokit #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javorszky
commented
Feb 3, 2023
|
|
||
| ll.Err(err). | ||
| Str("requestID", c.Request().Header.Get(echo.HeaderXRequestID)). | ||
| Msg("request returned an error") |
There was a problem hiding this comment.
Change 1 is here. Regardless of what the error is, it needs to be logged. The logger on line 54 would log the error that gets returned from c.JSON or c.NoContent.
javorszky
commented
Feb 3, 2023
| if c.Echo().Debug { | ||
| message = echo.Map{"code": code, "message": m, "error": err.Error()} | ||
| } else { | ||
| message = echo.Map{"code": code, "message": m} |
There was a problem hiding this comment.
Change 2 is here. The "code": code, was added to both messages.
See original: https://github.com/labstack/echo/blob/82a964c657e26b68998393d3e7291f1a474447f8/echo.go#L414-L416
rnpridgeon
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Custom error handler that's a literal copy of echo's current built in error handler with two changes. The changes will be pointed out in code comments.