Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update otel meter provider 0.9.0 -> 0.10.0 and 0.31.0 -> 0.32.0 #4

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

javorszky
Copy link
Contributor

@javorszky javorszky commented Sep 28, 2022

the otel monorepo changed the API signatures, so a regular renovate bot update was not enough.

This PR updates the dependencies to the latest available at the time of the PR with the necessary modifications to the consuming code.

This also means that other code that uses this will need to deal with the returned shutdown function as the signature of the new otelmeter function changed

@javorszky
Copy link
Contributor Author

I have also changed / introduced something called "temporality". Previously it was cumulative, as the default, now it's delta.

From the otel meter code (https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/metricdata/temporality.go):

// Temporality defines the window that an aggregation was calculated over.
type Temporality uint8

const (
	// undefinedTemporality represents an unset Temporality.
	//nolint:deadcode,unused,varcheck
	undefinedTemporality Temporality = iota

	// CumulativeTemporality defines a measurement interval that continues to
	// expand forward in time from a starting point. New measurements are
	// added to all previous measurements since a start time.
	CumulativeTemporality

	// DeltaTemporality defines a measurement interval that resets each cycle.
	// Measurements from one cycle are recorded independently, measurements
	// from other cycles do not affect them.
	DeltaTemporality
)

@rnpridgeon
Copy link

This will be an ongoing issue so long as atmo/e2core and scn continues to use otel directly while sat uses go-kit. We should make it a pretty high priority to get e2core and scn updated with go-kit and replace any direct usage of otel (and fix our circular dependencies of course)

@javorszky
Copy link
Contributor Author

Yep, the next step is to integrate this with the others

@javorszky javorszky merged commit 817f7ab into main Sep 28, 2022
@javorszky javorszky deleted the gabor/upgrade-otel-meterprovider branch September 28, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants