[rwasm] Call wasm module start before init
#130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohix
previously approved these changes
Aug 13, 2021
|
I'm now thinking about Flight Deck customers, they would have modules sitting in storage that use |
cohix
dismissed
their stale review
Wondering about Flight Deck backwards compat
ospencer
changed the title
initinit
cohix
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a call to a wasm runnable's start function (usually called
_start, but can have other names).Swift modules can now write any initialization code in the module's body. AssemblyScript and Rust modules can export an explicit
_startfunction.Closes #127.