Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce file and folder permissions across subo #172

Merged
merged 2 commits into from Jan 21, 2022
Merged

Reduce file and folder permissions across subo #172

merged 2 commits into from Jan 21, 2022

Conversation

danielledeleo
Copy link
Contributor

I went through Subo and adjusted the file permissions according to the following rules:

  • directories are all 0755
  • locally cached and temporary files are 0644
  • runnable source files are 0600

Fixes #171

denopink
denopink reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if we made these permissions constants in package util? It may help future contributors if we had something as obvious as util.FilePrem and etc.

@cohix
Copy link
Contributor

cohix commented Jan 20, 2022

@jagger27 I like @denopink 's suggestion :) Let's do that, and then this looks good!

denopink
denopink approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@danielledeleo danielledeleo merged commit 96014a2 into main Jan 21, 2022
@javorszky javorszky mentioned this pull request Feb 7, 2022
Merged
@arbourd arbourd deleted the jagger/file-permissions branch April 28, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cohix cohix cohix approved these changes

@denopink denopink denopink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subo create runnable creates files with exec permissions
3 participants
@danielledeleo @cohix @denopink