vtest: Automated testing for vektor servers #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a separate `TestStart` function, setting TestMode to true prevents the server from fully starting and listening on a socket.
vtest allows users to run automated tests against their routes without spinning up a full server.
Assertions are now chainable on a single request. e.g.:
`vt.Run(req, t).AssertStatus(200).AssertHeader("Content-Type", "application/json")`
Rename VKTest to VTest Rename helpers.go to vtest.go Rename several internal functions and constants to be unexported [*]: I don't think there is an elegant way to create a proper go doc Example section showing how to *define* a testing function, so I just put it in the overview. Single-file Examples can't contain functions with a func(t *testing.T) signature, for whatever reason. (see https://pkg.go.dev/testing#hdr-Examples)
This way, when you call multiple Assert* methods on a single response, it prints test output data for each assertion.
Example:
=== RUN TestNotFound
=== RUN TestNotFound/body
=== RUN TestNotFound/status
--- PASS: TestNotFound (0.00s)
--- PASS: TestNotFound/body (0.00s)
--- PASS: TestNotFound/status (0.00s)
danielledeleo
force-pushed
the
jagger/vtest
branch
from
e7ed4b5
to
47bccbc
Compare
cohix
reviewed
Aug 13, 2021
cohix
reviewed
Aug 13, 2021
- Add check to prevent server from starting twice
- Replace t.Error() + t.FailNow() calls with t.Fatal()
cohix
approved these changes
Aug 13, 2021
| @@ -48,6 +49,12 @@ func New(opts ...OptionsModifier) *Server { | |||
|
|
|||
| // Start starts the server listening | |||
| func (s *Server) Start() error { | |||
| if s.started.Load().(bool) { | |||
There was a problem hiding this comment.
Were we not checking this anywhere before? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53