Remove redundant subscriptions.init() from EA API #2784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed to call
subscriptions.init(productId)
when aproductId
is provided in the page markup. Furthermore this init call can result in an error if the page has already been initialized outside of EA. This is causing an issue with 3P integrations where SwG.js may have been initialized by method calls likegetEntitlements()
prior toGaaMetering.init
.Therefore I propose the folllowings:
subscriptions.init()
from EA APIGaaMetering.getProductIDFromPageConfig_()
for a validation purpose i.e. ensuring the page hasproductId
in the markupInternal tracking: b/271063736