Fixed issue with null equality incorrectly being set. Closes #30

subsonic · Jul 9, 2009 · e670ec5 · e670ec5
1 parent 08ee5c3
commit e670ec5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/SubSonic.Core/Linq/Structure/TSqlFormatter.cs b/SubSonic.Core/Linq/Structure/TSqlFormatter.cs
@@ -639,6 +639,22 @@ protected override Expression VisitBinary(BinaryExpression b)
                         }
                         break;
                     case ExpressionType.Equal:
+                        if (right.NodeType == ExpressionType.Constant) {
+                            ConstantExpression ce = (ConstantExpression)right;
+                            if (ce.Value == null) {
+                                this.Visit(left);
+                                sb.Append(" IS NULL");
+                                break;
+                            }
+                        } else if (left.NodeType == ExpressionType.Constant) {
+                            ConstantExpression ce = (ConstantExpression)left;
+                            if (ce.Value == null) {
+                                this.Visit(right);
+                                sb.Append(" IS NULL");
+                                break;
+                            }
+                        }
+                        goto case ExpressionType.LessThan;
                     case ExpressionType.NotEqual:
                         if (right.NodeType == ExpressionType.Constant)
                         {

diff --git a/SubSonic.Tests/SubSonic.Tests.csproj b/SubSonic.Tests/SubSonic.Tests.csproj
@@ -58,6 +58,7 @@
     </Reference>
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="BugReports\LinqGeneratorBugs.cs" />
     <Compile Include="DataProviders\ProviderFactoryTests.cs" />
     <Compile Include="LINQ\BugReports.cs" />
     <Compile Include="SimpleQuery\BatchTests.cs" />
@@ -111,7 +112,6 @@
     </ProjectReference>
   </ItemGroup>
   <ItemGroup>
-    <Folder Include="BugReports\" />
     <Folder Include="Transactions\" />
   </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />