-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace subspace-runtime
with subspace-fake-runtime-api
#187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed commit that removes genesis config usage, please rebase and squash once upstream PR is updated
BTW this PR should proably be updated once upstream PR is merged, so we have commit from |
thanks, this is a lot better! couldn't think of using
yes, I would update the commit hash here once that PR was merged. |
That generic is meaningful for legacy API that is soon to be removed from Substrate. When decoding from JSON it is not involved in anything and makes no difference, hence |
subspace-runtime
dependency and use subspace_service::fake_runtime
subspace-runtime
dependency and use subspace-fake-runtime-api
4a52b5c
to
514790e
Compare
subspace-runtime
dependency and use subspace-fake-runtime-api
subspace-runtime
with subspace-fake-runtime-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The impact of this should be even more than it seems because build step of subspace-runtime
was compiling a lot of stuff, now all of it is gone. Thanks!
Remove runtime genesis config usage Update subspace commit hash
514790e
to
c8ad481
Compare
companion PR autonomys/subspace#2735
Before:
Building [===========> ] 708/1336:
Now:
Building [=====================> ] 1257/1268