Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/add reddit socials #200

Merged
merged 2 commits into from Aug 15, 2023
Merged

Conversation

JustinMKY
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 12, 2023

Deploy Preview for cosmic-selkie-827ba7 ready!

Name Link
🔨 Latest commit f3b3228
🔍 Latest deploy log https://app.netlify.com/sites/cosmic-selkie-827ba7/deploys/64db86f7de51a40008eaf835
😎 Deploy Preview https://deploy-preview-200--cosmic-selkie-827ba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JustinMKY for adding Reddit to the list of community resources! Are you the person who started the subReddit and will be moderating the space?

I'll leave a few suggestions before we can merge your PR:

  1. Please revert changes made to the docusaurus.config.js as the links there are only official Subspace-moderated community resources
  2. Please add a link to Reddit to the versioned version of docs/community/index.md, you can find it in /versioned_docs/version-latest/community/index.md

Looking forward to the updates, thanks!

@@ -24,6 +24,10 @@ Please note, all community provided resources are **non-official**. For clarific

🇹🇷 - [türk telegram topluluğu](https://t.me/subspacenetworkturkey)

### Reddit

🇺🇸 - [English Subreddit Community](https://www.reddit.com/r/SubspaceNetwork/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same section to the versioned_docs.
You can find the same file index.md located in /versioned_docs/version-latest/community/index.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@@ -190,7 +190,7 @@ const config = {
},
{
label: 'Reddit',
href: 'https://reddit.com/r/sub',
href: 'https://www.reddit.com/r/SubspaceNetwork/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change as this section should only point to official (not community-lead) Subspace resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted change.

@JustinMKY
Copy link
Contributor Author

Thank you @JustinMKY for adding Reddit to the list of community resources! Are you the person who started the subReddit and will be moderating the space?

I'll leave a few suggestions before we can merge your PR:

  1. Please revert changes made to the docusaurus.config.js as the links there are only official Subspace-moderated community resources
  2. Please add a link to Reddit to the versioned version of docs/community/index.md, you can find it in /versioned_docs/version-latest/community/index.md

Looking forward to the updates, thanks!

Correct, I am moderating the community subreddit

Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates @JustinMKY, LGTM!

Looking forward to more contributions, keep up the good work!

@EmilFattakhov EmilFattakhov merged commit 3671965 into subspace:main Aug 15, 2023
1 check passed
@JustinMKY JustinMKY deleted the social-update branch August 16, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants