Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'Attach here and now' command for screen and tmux #208

Merged
merged 1 commit into from Aug 22, 2023

Conversation

extSunset
Copy link
Contributor

@extSunset extSunset commented Aug 18, 2023

See #164

@extSunset
Copy link
Contributor Author

I'm not sure whether to completely replace the existing command set, so I've added the 'Attach here and now' command as an add-on for now.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for cosmic-selkie-827ba7 ready!

Name Link
🔨 Latest commit f76732e
🔍 Latest deploy log https://app.netlify.com/sites/cosmic-selkie-827ba7/deploys/64e3c7c5ab6a20000810464a
😎 Deploy Preview https://deploy-preview-208--cosmic-selkie-827ba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @extSunset!

I'm not sure whether to completely replace the existing command set, so I've added the 'Attach here and now' command as an add-on for now.

I think you made a right call, it's all very clear!

Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment @extSunset : Similar to 207, let's add the same sections to the "latest version" of docs.

Thanks a lot!

@extSunset
Copy link
Contributor Author

@EmilFattakhov Done

@EmilFattakhov
Copy link
Contributor

Great work @extSunset!

@EmilFattakhov EmilFattakhov merged commit d7a7ae8 into subspace:main Aug 22, 2023
1 check passed
@extSunset extSunset deleted the improve-screen-and-tmux branch August 22, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants