Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-compose generator: Remove the 'volume' section if unneeded. #231

Merged
merged 1 commit into from Aug 29, 2023

Conversation

extSunset
Copy link
Contributor

@extSunset extSunset commented Aug 28, 2023

Solves the same problem as #229. This is my option to solve this problem. I hope that in the end a better solution will be chosen or a new one will be born.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for cosmic-selkie-827ba7 ready!

Name Link
🔨 Latest commit ffb883f
🔍 Latest deploy log https://app.netlify.com/sites/cosmic-selkie-827ba7/deploys/64ece2fd96bdfb0008dabf66
😎 Deploy Preview https://deploy-preview-231--cosmic-selkie-827ba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilFattakhov EmilFattakhov mentioned this pull request Aug 29, 2023
Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @extSunset for a really clean solution, love it!

@EmilFattakhov EmilFattakhov merged commit db4910a into subspace:main Aug 29, 2023
1 check passed
@extSunset extSunset deleted the docker-generator-fix branch August 29, 2023 14:36
@mathematicw
Copy link
Contributor

I suggest to improve the Docker-compose generator" code a little bit - to follow Docker improvements.
𝘛𝘩𝘦 𝘭𝘢𝘵𝘦𝘴𝘵 𝘷𝘦𝘳𝘴𝘪𝘰𝘯𝘴 𝘰𝘧 𝘥𝘰𝘤𝘬𝘦𝘳 𝘤𝘰𝘮𝘱𝘰𝘴𝘦 "𝘶𝘯𝘥𝘦𝘳𝘴𝘵𝘢𝘯𝘥" 𝘭𝘰𝘤𝘢𝘭 𝘱𝘢𝘵𝘩𝘴 𝘧𝘰𝘳 𝘷𝘰𝘭𝘶𝘮𝘦𝘴. And so we could allow relative paths in the generator. Now it only accepts full absolute paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants