Fix color scheme. #233
Merged
Fix color scheme. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extSunset
changed the title
✅ Deploy Preview for cosmic-selkie-827ba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
A silly mistake, though. |
extSunset
force-pushed
the
fix-color-scheme
branch
2 times, most recently
from
3ff1d63
to
be0260b
Compare
|
Infirma -> Infima... |
The colours have been changed for softer ones. The commit covers most of the main Infirma colours for the light theme and separately code blocks. The colours of the titles in the footer have also been fixed (they were white in the light theme, making them invisible). Makes text in codeblocks `--ifm-color-primary-darker`.
extSunset
force-pushed
the
fix-color-scheme
branch
from
37415eb
to
536509f
Compare
There was a problem hiding this comment.
This is a great improvement @extSunset, the light mode is no longer blinding 👓!
The only thing that stood out to me was the code-blocks on the light scheme. What do you think about wrapping them in a darker border, or slightly adjusting the background color?
For comparison, code blocks stand out in a dark mode, but not in a light mode
|
@EmilFattakhov I'll try playing around with different options. It might be worth adding a shadow to the block. |
Added shadows to code blocks, menu details, and alert blocks. The main goal was to improve the visibility of code blocks in the light theme. Shadows were added to the other elements to maintain a unified style. Shadows were added to the dark theme for the same reason, also the lack of shadows in the dark theme caused blocks to distort when switching themes.
… variables. The footer colour has been changed to a darker colour, similar to the original light theme. Shadow colour for code blocks in the light theme was made dependent on CSS variables.
EmilFattakhov
approved these changes
Aug 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aimed at improving the colour scheme, particularly for the light theme which was suffering from excessive brightness. I'm really looking forward to the comments on this. I am not a designer, and this is my attempt to improve the condition of the light theme in some way.
Should fix #216 and #214.