Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeblocks. #234

Merged
merged 1 commit into from Aug 31, 2023
Merged

Fix codeblocks. #234

merged 1 commit into from Aug 31, 2023

Conversation

extSunset
Copy link
Contributor

Removes unnecessary newlines in blocks, removes unnecessary indentation. Changes the languages for some blocks.

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for cosmic-selkie-827ba7 ready!

Name Link
🔨 Latest commit 7f61b1d
🔍 Latest deploy log https://app.netlify.com/sites/cosmic-selkie-827ba7/deploys/64f0642b50372c0008326cb7
😎 Deploy Preview https://deploy-preview-234--cosmic-selkie-827ba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @extSunset!

Left one small suggestion, Please let me know your opinion about weird highlighting. Curious to hear you're okay with it, or find it peculiar too.

@@ -68,21 +68,21 @@ Creating a filesystem with a chunk (sunit) size of 32KB can prevent data fragmen

**XFS**

```
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest keeping the next three code blocks without bash instructions, as the result color scheme looks a bit weird. It highlights the words that wouldn't have been highlighted in a terminal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think I'll remove the highlighting in all places with one-line commands like this one. Except for tmux/screen ones.

Removes unnecessary newlines in blocks, removes unnecessary indentation.
Changes the syntax highlighting for some blocks.
@extSunset
Copy link
Contributor Author

I tried using shell-session, but it seems to work a bit differently than I expected.

Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @extSunset!

@EmilFattakhov EmilFattakhov merged commit b16dda4 into subspace:main Aug 31, 2023
1 check passed
@extSunset extSunset deleted the codeblock-fixes branch September 1, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants