Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: out-of-date link #264

Merged
merged 1 commit into from Oct 5, 2023
Merged

Conversation

hairtail
Copy link
Contributor

This PR fixes a bug cause by out-of-date link.

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for cosmic-selkie-827ba7 ready!

Name Link
🔨 Latest commit 8298ed0
🔍 Latest deploy log https://app.netlify.com/sites/cosmic-selkie-827ba7/deploys/6514d746d4c151000839fdbd
😎 Deploy Preview https://deploy-preview-264--cosmic-selkie-827ba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hairtail hairtail changed the title Fix: out-of-data link Fix: out-of-date link Sep 28, 2023
Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion @hairtail, keep them coming!

Please have another look at our released documentation available here and confirm if the link is indeed broken?
Both links seem to work well on my end.

@hairtail
Copy link
Contributor Author

Thank you for your suggestion @hairtail, keep them coming!

Please have another look at our released documentation available here and confirm if the link is indeed broken? Both links seem to work well on my end.

Doesn't work for me. The official materials links to /intro while it should be /docs/intro.
image

@hairtail
Copy link
Contributor Author

hairtail commented Sep 29, 2023

Seems it does work if we open the community resources page directly with url. But doesn't work if we jump to the community resources page from page header navigation bar. You can have a try to confirm.

@EmilFattakhov
Copy link
Contributor

Oh, I see @hairtail, thank you for clarification. I can confirm that the link becomes broken in case the user proceeds to the page using a dropdown, but links continue to work fine if they access the page from the side menu.

I will request a small change because currently, the link takes users to the pre-released version of the page in both cases. Good catch @hairtail!

@hairtail
Copy link
Contributor Author

Oh, I see @hairtail, thank you for clarification. I can confirm that the link becomes broken in case the user proceeds to the page using a dropdown, but links continue to work fine if they access the page from the side menu.

I will request a small change because currently, the link takes users to the pre-released version of the page in both cases. Good catch @hairtail!

Alright

@@ -11,7 +11,7 @@ keywords:

:::caution

Please note, all community provided resources are **non-official**. For clarification please refer to [official materials](../intro).
Please note, all community provided resources are **non-official**. For clarification please refer to [official materials](/docs/intro).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link ignores the selected documentation version, for the latest version, in this case, I believe it should be along the lines of (/versioned-docs/version-latest/intro). Please make sure to test it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be some issues since I'm not really familiar with this repo very well. Btw, do we need this changes now? Seems we have figure out the issue and can be fixed in other ways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, no problem I'm going to get it fixed. Thanks!

@EmilFattakhov EmilFattakhov merged commit a59491f into subspace:main Oct 5, 2023
1 check passed
@hairtail hairtail deleted the fix-not-found branch October 5, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants