New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: out-of-date link #264
Conversation
✅ Deploy Preview for cosmic-selkie-827ba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't work for me. The official materials links to |
Seems it does work if we open the community resources page directly with url. But doesn't work if we jump to the community resources page from page header navigation bar. You can have a try to confirm. |
Oh, I see @hairtail, thank you for clarification. I can confirm that the link becomes broken in case the user proceeds to the page using a dropdown, but links continue to work fine if they access the page from the side menu. I will request a small change because currently, the link takes users to the pre-released version of the page in both cases. Good catch @hairtail! |
Alright |
@@ -11,7 +11,7 @@ keywords: | |||
|
|||
:::caution | |||
|
|||
Please note, all community provided resources are **non-official**. For clarification please refer to [official materials](../intro). | |||
Please note, all community provided resources are **non-official**. For clarification please refer to [official materials](/docs/intro). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link ignores the selected documentation version, for the latest version, in this case, I believe it should be along the lines of (/versioned-docs/version-latest/intro)
. Please make sure to test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be some issues since I'm not really familiar with this repo very well. Btw, do we need this changes now? Seems we have figure out the issue and can be fixed in other ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, no problem I'm going to get it fixed. Thanks!
This PR fixes a bug cause by out-of-date link.