Erasure coding commitments #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
vedhavyas,
liuchengxu,
shamil-gadelshin,
dariolina and
rahulksnv
…r and piece reconstructor to improve performance
nazar-pc
force-pushed
the
erasure-coding-commitments
branch
from
2ef7fdc
to
6e14833
Compare
dariolina
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves 4th item from #1163 and improves archiving performance by erasure coding commitments rather than creating them for half of the records in segment.
Before (one segment start to finish, it is not as bad with incremental commitment):
After:
Resolves #1163
Code contributor checklist: