Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix polynomial normalization #1454

Merged
merged 1 commit into from May 15, 2023
Merged

Fix polynomial normalization #1454

merged 1 commit into from May 15, 2023

Conversation

nazar-pc
Copy link
Member

Some polynomials containing just zeroes were reduced to nothing, causing issues when trying to create witness for corresponding records. I think we should leave at least one element in there.

Code contributor checklist:

@nazar-pc nazar-pc requested a review from dariolina May 13, 2023 14:50
Base automatically changed from parallel-chiapos to main May 13, 2023 15:43
dariolina
dariolina approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@dariolina dariolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, we weren't considering the fact they can all be 0s.

@nazar-pc nazar-pc merged commit 16a64da into main May 15, 2023
9 checks passed
@nazar-pc nazar-pc deleted the fix-poly-normalization branch May 15, 2023 09:14
i1i1 added a commit to subspace/subspace-pulsar-sdk that referenced this pull request May 16, 2023
@i1i1
Import subspace/subspace#1441,subspace/subspace#1448,subspace/subspac…
36e9fa9 
…e#1450,subspace/subspace#1453,subspace/subspace#1454,subspace/subspace#1455,subspace/subspace#1456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariolina dariolina dariolina approved these changes

@liuchengxu liuchengxu Awaiting requested review from liuchengxu

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nazar-pc @dariolina