Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve abstraction a bit #1489

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Improve abstraction a bit #1489

merged 1 commit into from
Jun 2, 2023

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Jun 2, 2023

I think inversion of consensus/compact blocks dependency might be helpful, but this PR focuses on the simple fact that one of the requests was not wrapped in ServerRequest and NetworkPeerHandle was unnecessarily made aware of that with extra generics.

Code contributor checklist:

@nazar-pc nazar-pc requested a review from rahulksnv June 2, 2023 11:52
rahulksnv
rahulksnv approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@rahulksnv rahulksnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@nazar-pc nazar-pc merged commit 106ecf9 into rsub/compact-block-regression Jun 2, 2023
@nazar-pc nazar-pc deleted the rsub/compact-block-regression-improve-abstraction branch June 2, 2023 11:57
i1i1 added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jun 22, 2023
@i1i1
Import autonomys/subspace#1476,autonomys/subspace#1480,autonomys/subs…
bc12635 
…pace#1489,autonomys/subspace#1489,autonomys/subspace#1477,autonomys/subspace#1481,autonomys/subspace#1496,autonomys/subspace#1497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulksnv rahulksnv rahulksnv approved these changes

@liuchengxu liuchengxu Awaiting requested review from liuchengxu

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazar-pc @rahulksnv