Refactor sync from DSN #1565
Merged
Refactor sync from DSN #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial_block_import_from_dsn` before adding more versions of the function
…sable `import_blocks_from_dsn`
i1i1
added a commit
to subspace/subspace-pulsar-sdk
that referenced
this pull request
Jun 23, 2023
jfrank-summit
pushed a commit
to subspace/subspace-pulsar-sdk
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks I did working towards #1508
First commit removes annoying warning when node tries to finalize genesis block, the other two commits result in reusable
import_blocks_from_dsnfunction that works with sharableImportQueueServicerather thanImportQueue(which is consumed by Substrate's networking and can't be shared).import_blocks_from_dsnwill later be called from more places.Last commit fixed subspace networking disconnection from peers while heavy block importing is happening by letting it run in dedicated thread.
Code contributor checklist: