Make plotting/replotting thread pools distinct for farms to avoid stack overflow, still protected by semaphores #2167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having multiple
ThreadPool::install()
apears to be problematic as described in rayon-rs/rayon#751Since #2095 we have separate concurrency parameters for sector downloading and encoding, so we will not have two sectors plotting at the same time unless user wants to anyway. BTW it would open the option to have thread pool size smaller per plot and allow multiple sectors to be encoded at the same time on larger machines to not cross NUMA boundaries, but farmer would need to become NUMA-aware for that to make sense (and at that point it can do such things automatically when NUMA is detected).
Code contributor checklist: