Set CollectedBlockFees to an empty value during block initialization #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't remove the value completely because the fraud proof need to generate a proof of empty value for this storage Signed-off-by: linning <linningde25@gmail.com>
vedhavyas
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't remove the
CollectedBlockFeesvalue completely because the fraud proof needs to generate a proof of empty value for this storage, this is similar to how we handled theDomainChainAllowlistUpdatestorage in 9dba588I also checked all other storage proofs, they should not have this problem.
BTW, an interesting finding, if a storage does not exist in the state:
ValueQuery, it can successfully generate storage proof but fail withMissingValueerror when verifying the proof (e.g.CollectedBlockFees)OptionQuery, it will fail withMissingValueerror when generating the storage proof (e.g.DomainChainAllowlistUpdate)Code contributor checklist: