Minor refactoring for better readability #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuchengxu
reviewed
May 25, 2022
nazar-pc
force-pushed
the
prune-receipts-relative-to-best-execution-chain-number-refactor
branch
from
9007ee7
to
f6cc7a0
Compare
liuchengxu
approved these changes
May 25, 2022
liuchengxu
merged commit d769626
into
prune-receipts-relative-to-best-execution-chain-number
liuchengxu
deleted the
prune-receipts-relative-to-best-execution-chain-number-refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should be easier to read (unfortunately
core::iter::Stepis unstable, so I can't add it to Substrate'sHeader::Numberbound yet to make it even nicer).Checked subtraction the way it is written here is easier to analyze:
PRUNING_DEPTHis0, clearly everything will be removed, not something we want, but makes sense1then just last entry will remain, also makes sense and extends to any numberThis way it is trivial to prove correctness and easy to explain with plain English words. And we really don't want saturation here, we want to check if there is something to remove.
new_first_saved_receipt = delete_receipts_up_to + 1is also natural since we obviously can't set it to the same receipt number that we are about to delete.