Optimized AArch64 executables #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozgunozerk
reviewed
Jun 28, 2022
| # Build at least something for aarch64 that doesn't exceed CI's time limit | ||
| profile: dev | ||
| # We build AArch64 | ||
| - arch: linux/amd64 |
There was a problem hiding this comment.
what is the reason that this is not arm64 if we are using this for aarch64 builds?
There was a problem hiding this comment.
was it faster to use amd64 instead of arm64? I remember that cross-compilation was surprisingly fast :D
There was a problem hiding this comment.
Check the rest of the changes, we use cross-compilation instead of virtualization now
i1i1
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from
debugAArch64 Linux builds that took 2.5 hours for farmer and 5.5 hours for node toproductionoptimized builds that take 25 minutes to build for farmer and 50 minutes for node, cutting time for release publishing significantly 🎉This also makes all builds compile Rust's standard library as part of the build. Was only necessary for cross-compilation as standard library wasn't available for this target (might be just one rustc build, but still), but I decided to switch to that everywhere for consistency.
Workflow run: https://github.com/subspace/subspace/actions/runs/2573340931