Don't `require('buffer')` #22

Open
tellnes opened this Issue Aug 8, 2013 · 3 comments

Projects

None yet

2 participants

@tellnes
Contributor
tellnes commented Aug 8, 2013

The buffer implementation is a lot of code and http-browserify does not really need it to work. It is only needed for auth parameter to bas64 encode it.

Could it be document that the auth parameter is not supported or changed to depend on a base64 library or? Eg. base64-js which buffer-browserify depends on.

feross commented Dec 5, 2013

Where do you see require('buffer')? It looks like buffer is not directly required by http-browserify but rather by stream, which is needed to make the request and response objects be streams. Streams operate on Buffers, so it's required.

Contributor
tellnes commented Sep 9, 2014

When I filled this was buffer directly required by http-browserify. Probably did someone resolve it and now, it has been reintroduced by stream.

feross commented Jul 8, 2015

This issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment