Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1194 #1195

Merged
1 commit merged into from Apr 3, 2015
Merged

Fix #1194 #1195

1 commit merged into from Apr 3, 2015

Conversation

jcppman
Copy link
Contributor

@jcppman jcppman commented Apr 3, 2015

since 9.0.6, bundle() returns a read-only stream by var output = readonly(this.pipeline)

but if this._bundled is true, a 'reset' will be triggered, which cause the
problem mentioned in #1194, because this.pipeline !== output after this.reset(), they are not the same thing anymore.

if this._bundled is true, a 'reset' will be triggered, which cause the
problem mentioned in browserify#1194, because this.pipeline !== output after this.reset()
@terinjokes
Copy link
Contributor

LGTM. Possible to get a test in for this?
On Apr 3, 2015 9:22 AM, "Chriest Yu" notifications@github.com wrote:

since 9.0.6, bundle() returns a read-only stream by var output =
readonly(this.pipeline), but if this._bundled is true, a 'reset' will be
triggered, which cause the
problem mentioned in #1194
#1194, because this.pipeline

!== output after this.reset()

You can view, comment on, or merge this pull request online at:

#1195
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1195.

@ghost ghost merged commit b63cc79 into browserify:master Apr 3, 2015
@ghost
Copy link

ghost commented Apr 3, 2015

Published in 9.0.7 with a test case. Thanks for the patch!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants