Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a replacement module for the current zlib module being used by browserify that supports the full Node zlib API. It uses the actual JS zlib code from Node, and passes Node's zlib tests by basically implementing the C++ binding that Node uses on top of pako, which is a direct port of zlib to JS. This means that the full API is implemented (including streaming, async, sync, etc.), the API and behavior exactly matches Node, and because pako is a direct port of zlib, the output is binary identical to the output produced by Node's zlib module. Also, pako is way faster than the zlib library being used by the current module (see benchmarks on their repo compared to imaya). The only things not implemented yet are the
params
method and thedictionary
option because pako doesn't have the underlying methods for those yet, but I hope to write patches for those soon. Let me know what you think!