Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreTransform to check for pkg.browserify.transform #966

Closed
wants to merge 1 commit into from
Closed

ignoreTransform to check for pkg.browserify.transform #966

wants to merge 1 commit into from

Conversation

kahwee
Copy link

@kahwee kahwee commented Oct 31, 2014

There is an edge case where ignoreTransform will not work if your package.json specify transforms in an array format.

    "browserify": {
        "transform": [
            ["reactify", {
                "es6": true
            }],
            "bulkify", ["browserify-istanbul", {
                "ignore": ["**/*/*.json"]
            }]
        ]
    }

This change checks if it is an array and extract the index0 to check for the name of the transform.

There is an edge case where ignoreTransform will not work if your package.json specify transforms in an array format.

```
	"browserify": {
		"transform": [
			["reactify", {
				"es6": true
			}],
			"bulkify", ["browserify-istanbul", {
				"ignore": ["**/*/*.json"]
			}]
		]
	}
```

This change checks if it is an array and extract the index0 to check for the name of the transform.
@ghost
Copy link

ghost commented Nov 11, 2014

Thanks for the patch! Merged in 6.3.1.

@ghost ghost closed this Nov 11, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant