-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] properly handle paths with a trailing slash #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind rebasing as well when making these changes, and checking the "allow maintainers to edit" checkbox?
@@ -0,0 +1,2 @@ | |||
node_modules | |||
npm-debug.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert the gitignore changes; it's unrelated to this PR.
@@ -0,0 +1 @@ | |||
require('./test/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a trailing newline on this file
@@ -0,0 +1 @@ | |||
console.log('file') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a trailing newline on this file
@@ -0,0 +1 @@ | |||
console.log('folder') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a trailing newline on this file
var path = require('path') | ||
|
||
test('issue 51', function (t) { | ||
t.ok(resolve.sync('./issue51/test/') === path.resolve(__dirname, 'issue51/test/index.js')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also ensure that ./issue51/test/
is not equal to ./issue51/test
when there's a test.js
file?
#51