Document unexpected t.end() behavior
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this! |
|
@kl0tl I suppose And But sync part may use |
|
Basically, |
|
Yup, yeah pretty much - for consistency I never use |
This comment has been minimized.
This comment has been minimized.
ljharb
approved these changes
Jan 4, 2021
ljharb
force-pushed
the
docs/troubleshooting
branch
from
08245ef
to
b505c4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 19 19
Lines 766 766
Branches 146 146
=======================================
Hits 568 568
Misses 198 198 Continue to review full report at Codecov.
|
ljharb
added a commit
that referenced
this pull request
Jan 4, 2021
- [Fix] preserve stack traces for returned Promises (async/await) (#537) - [Robustness] cache and call-bind more prototype methods - [Refactor] use `call-bind/callBound` instead of `function-bind` directly - [readme] Document unexpected `t.end()` behavior (#279) - [readme] Added tabe into reporter list (#249) - [readme] improve method docs - [meta] do not publish github action workflow files - [meta] run `aud` in `posttest` - [meta] add Automatic Rebase and Require Allow Edits workflows - [eslint] ensure no trailing commas - [eslint] fix some inconsistencies - [Tests] make `stripFullStack` output an array of lines, for better failure messages - [Tests] add `npm run test:example` to test non-failing examples. - [Tests] migrate tests to Github Actions (#538) - [Tests] skip Promise tests when Promises are not available - [Tests] run `nyc` on all tests - [Tests] add `timeoutAfter` test with Promises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #222 for motivation.