Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BrowserDOMElement.getAttributes #565

Closed
michael opened this issue Apr 21, 2016 · 1 comment
Closed

Improve BrowserDOMElement.getAttributes #565

michael opened this issue Apr 21, 2016 · 1 comment
Milestone

Comments

@michael
Copy link
Member

michael commented Apr 21, 2016

We expect getting the HTML or XML attributes here. However, this method is used in a special way internally and has different semantics.

We should move the component specific code somewhere else and let getAttributes behave as expected.

https://github.com/substance/substance/blob/master/ui/BrowserDOMElement.js#L65

@obuchtala
Copy link
Member

This is ok now.

@obuchtala obuchtala modified the milestone: Beta 4 Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants