Node selection clone #769
Closed
Node selection clone #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheerio has a custom `type` attribute which it sets to `tag` for
most elements but to `script` for scripts. This fix provides for
consistent behavious with `BrowserDOMElement`. Note that in both
Chrome and Firefox `document.createElement('script').nodeType === window.Node.ELEMENT_NODE`
This message is sent by the `CollabServer`. This change simply removes the distracting console warning every 30s. I'm not sure that this is the best way to deal with this long term.
This method was not implemented and was causing an error in Stencila Document's integration of Substance. All other classes derived from Selection have this method (e.g. ContainerSelection, PropertySelection) so it appears to be an omission.
|
Closing this as have cherry picked this commit into #764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was not implemented and was causing an error in Stencila Document's integration of Substance. All other classes derived from Selection have this method (e.g. ContainerSelection, PropertySelection) so it appears to be an omission.
Sorry, was attempting to cherry pick a single commit for this PR but failed, so it includes commits also in #764.