Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema for tpcds queries #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

richtia
Copy link
Member

@richtia richtia commented Aug 17, 2022

Adding the schema for TPC-DS queries

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2022

CLA assistant check
All committers have signed the CLA.

@jacques-n
Copy link
Collaborator

@richtia , any chance you want to also add at least a smoke test that uses this? It seems lonely right now.

@JamesRTaylor
Copy link
Contributor

JamesRTaylor commented Jan 26, 2023

@richtia - thanks for the PR. Here's some feedback:

  • I like the idea of documenting the tpcds schema and being consistent with the tpch convention in terms of the location of the schema file. We actually use Calcite to define the tpch and tpcds schema, but having this documented is definitely useful too.
  • Remove the duplicate definition of this schema here.
  • Modify the test here that uses keyconstraints_schema.sql to use your new schema instead, and rename the test file to TpcdsSchemaTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants