Adding Join Suffix #220
Closed
Adding Join Suffix #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a UX concern for producers to handle rather than something that Substrait needs to model. What's the motivation for including it in Substrait? |
|
I don't know what a suffix is. The docs update doesn't do a good job of explaining the purpose. Searching around it seems like this has to do with field naming(?). Substrait plan nodes don't deal with names, only ordinal positions so if that is the purpose of this patch, it seems like there is a misunderstanding of how substrait works. |
|
@jacques-n this is a misunderstanding of the usage. Thanks a lot for pointing out. I closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to include the suffixes for join operations.